Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stub out __VITE_PRELOAD__ during prerender #126

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Jun 22, 2024

Closes #125

Dynamic imports now result in something like this:

(()=>import("./index-kayMhHeV.js"),__VITE_PRELOAD__)

Which then throws as Vite hasn't subbed it out.

It used to be a string like so:

(()=>import("./index-kayMhHeV.js"),"__VITE_PRELOAD__")

for reasons even the Vite team wasn't clear on (see reference in change)

@rschristian rschristian merged commit c6c7a0b into main Jun 23, 2024
1 check passed
@rschristian rschristian deleted the fix/prerender-preload branch June 23, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerendering incompatible with Vite 5.3 (5.2 is fine)
2 participants