Skip to content

Explicitly exclude jupyter files #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

hofbi
Copy link

@hofbi hofbi commented Apr 10, 2025

Alternative solution to #33.

identify also considers .ipynb files as json, which is correct. But I am very sure nobody wants to run json formatting on jupyter files, hence why not exclude it by default.

@hofbi hofbi marked this pull request as draft April 10, 2025 14:05
@hofbi
Copy link
Author

hofbi commented Apr 10, 2025

Making this a draft as I just found that --exclude-types is not yet supported here.

@asottile Let me know what you think of this solution. If you are fine with my approach, I would try to contribute the required argument to the mirror maker.

@asottile
Copy link
Member

I already rejected this in #33

@asottile asottile closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants