Add support for beatmap link parsing #242
Conversation
| // Checks if the beatmap string contains only numbers or if it's a file path | ||
| if (!Regex.IsMatch(beatmap, @"\A\d+\z|\.osu\z")) | ||
| { | ||
| string beatmapLinkPattern = @"osu\.ppy\.sh/b.*/\d+\z"; |
There was a problem hiding this comment.
This doesn't seem robust enough, I can name at least 4 ways of easily breaking it:
- Trailing slash
osu.ppy.sh/b/linksosu.ppy.sh/beatmaps/links- Inconsistent casing
There was a problem hiding this comment.
I agree with the point 1, although I don't see a case where it happens if you did copy and paste the beatmap link from the browser URL bar or from in-game.
I don't understand the point 2 and 3, as from my tests, osu.ppy.sh/b/ and osu.ppy.sh/beatmaps/ links work on my current implementation.
You're right about point 4, I didn't consider casing.
There was a problem hiding this comment.
Oh I misread the regex, 2 and 3 are indeed supported my bad. Would still prefer a more robust check though, because a completely incorrect link like osu.ppy.sh/boop/123 might match
There was a problem hiding this comment.
If I made the regex only match osu.ppy.sh/beatmapsets/b/beatmaps links, would it be enough?
There was a problem hiding this comment.
Sure, assuming we're talking just about the matching here. Other regex-related comments still apply
There was a problem hiding this comment.
Yes, it's only about the beatmap link match. I'll fix the other issues too.
| } | ||
|
|
||
| private void calculate() | ||
| private void checkBeatmapIdAndCalculate() |
There was a problem hiding this comment.
Note for self: this (and a lot of other things) needs to be separated into components
Currently, if you paste a beatmap link into the beatmap ID text box, it just deletes all non-number characters and ends up leaving the beatmapset ID mixed up with the beatmap ID. In this pr, I turned it into an
ExtendedLabelledTextBoxwith a regex filter on theSimulateScreenandBeatmapLeaderboardScreenclasses to check for beatmap links and extracting the correct ID from them.