Skip to content

Reduce overhead of async disposal #6918

Reduce overhead of async disposal

Reduce overhead of async disposal #6918

GitHub Actions / Results failed Feb 3, 2025 in 0s

25339 passed, 1 failed and 636 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded-Debug.trx 3167✅ 80⚪ 249s
TestResults-Linux-MultiThreaded-Release.trx 3167✅ 80⚪ 239s
TestResults-Linux-SingleThread-Debug.trx 3167✅ 80⚪ 189s
TestResults-Linux-SingleThread-Release.trx 3167✅ 80⚪ 158s
TestResults-macOS-MultiThreaded-Debug.trx 3168✅ 79⚪ 694s
TestResults-macOS-SingleThread-Debug.trx 3167✅ 1❌ 79⚪ 345s
TestResults-Windows-MultiThreaded-Debug.trx 3168✅ 79⚪ 289s
TestResults-Windows-SingleThread-Debug.trx 3168✅ 79⚪ 219s

✅ TestResults-Linux-MultiThreaded-Debug.trx

3247 tests were completed in 249s with 3167 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-MultiThreaded-Release.trx

3247 tests were completed in 239s with 3167 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-SingleThread-Debug.trx

3247 tests were completed in 189s with 3167 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-SingleThread-Release.trx

3247 tests were completed in 158s with 3167 passed, 0 failed and 80 skipped.

✅ TestResults-macOS-MultiThreaded-Debug.trx

3247 tests were completed in 694s with 3168 passed, 0 failed and 79 skipped.

❌ TestResults-macOS-SingleThread-Debug.trx

3247 tests were completed in 345s with 3167 passed, 1 failed and 79 skipped.

Test suite Passed Failed Skipped Time
osu.Framework.Tests.Graphics.TripleBufferTest 5✅ 1❌ 687ms

❌ osu.Framework.Tests.Graphics.TripleBufferTest

✅ TestReadOnly
❌ TestReadSaturated
	System.AggregateException : One or more errors occurred. (  Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
	  But was:  null
	)
	  ----> NUnit.Framework.AssertionException :   Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
	  But was:  null
	
	
	  1)   Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
	  But was:  null
	
	
✅ TestSameBufferIsNotWrittenTwiceInRowContestation
✅ TestSameBufferIsNotWrittenTwiceInRowNoContestation
✅ TestWriteOnly
✅ TestWriteThenRead

✅ TestResults-Windows-MultiThreaded-Debug.trx

3247 tests were completed in 289s with 3168 passed, 0 failed and 79 skipped.

✅ TestResults-Windows-SingleThread-Debug.trx

3247 tests were completed in 219s with 3168 passed, 0 failed and 79 skipped.

Annotations

Check failure on line 0 in TestResults-macOS-SingleThread-Debug.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Framework.Tests.Graphics.TripleBufferTest ► TestReadSaturated

Failed test found in:
  TestResults-macOS-SingleThread-Debug.trx
Error:
  System.AggregateException : One or more errors occurred. (  Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
    But was:  null
  )
    ----> NUnit.Framework.AssertionException :   Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
    But was:  null
  
  
    1)   Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
    But was:  null
  
  
Raw output
System.AggregateException : One or more errors occurred. (  Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
  But was:  null
)
  ----> NUnit.Framework.AssertionException :   Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
  But was:  null


  1)   Expected: <osu.Framework.Tests.Graphics.TripleBufferTest+TestObject ID: 2>
  But was:  null


   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task) in /Users/runner/work/osu-framework/osu-framework/osu.Framework/Extensions/TaskExtensions.cs:line 22
   at osu.Framework.Tests.Graphics.TripleBufferTest.TestReadSaturated() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Graphics/TripleBufferTest.cs:line 136
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
--AssertionException
   at NUnit.Framework.Assert.ReportFailure(String message)
   at NUnit.Framework.Assert.ReportFailure(ConstraintResult result, String message, Object[] args)
   at NUnit.Framework.Assert.That[TActual](TActual actual, IResolveConstraint expression, String message, Object[] args)
   at NUnit.Framework.Assert.That[TActual](TActual actual, IResolveConstraint expression)
   at osu.Framework.Tests.Graphics.TripleBufferTest.<>c__DisplayClass5_1.<TestReadSaturated>b__0() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Graphics/TripleBufferTest.cs:line 124
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
1)    at osu.Framework.Tests.Graphics.TripleBufferTest.<>c__DisplayClass5_1.<TestReadSaturated>b__0() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Graphics/TripleBufferTest.cs:line 124

2)    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task) in /Users/runner/work/osu-framework/osu-framework/osu.Framework/Extensions/TaskExtensions.cs:line 22
   at osu.Framework.Tests.Graphics.TripleBufferTest.TestReadSaturated() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Graphics/TripleBufferTest.cs:line 136
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
--AssertionException
   at NUnit.Framework.Assert.ReportFailure(String message)
   at NUnit.Framework.Assert.ReportFailure(ConstraintResult result, String message, Object[] args)
   at NUnit.Framework.Assert.That[TActual](TActual actual, IResolveConstraint expression, String message, Object[] args)
   at NUnit.Framework.Assert.That[TActual](TActual actual, IResolveConstraint expression)
   at osu.Framework.Tests.Graphics.TripleBufferTest.<>c__DisplayClass5_1.<TestReadSaturated>b__0() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Graphics/TripleBufferTest.cs:line 124
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)