Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pen input flow and map pen to touch on mobile platforms #6523

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

frenzibyte
Copy link
Member

After multiple attempts to try and fix ppy/osu#31570, this is one which brings back osu! to how it has been working before.

Now since direct/onscreen pen input is mapped to touch input, the entire pen input / ISourcedFromPen API becomes flaky and inconsistent, as not all pen input are sent as an ISourcedFromPen mouse event. For simplicity purposes, I have chosen to revert it completely until later time.

When returning back to resurrect this flow, special attention needs to be given into the following intertwined two problems:

  • PassThroughInputManager.syncReleasedInputs() should respect mouse input sourced from pen (currently sends release input without such context)
  • PassThroughInputManager.syncReleasedInputs() should be aware whether mouse button pressed from parent comes from mouse and not other input sources (main reason why it's impossible to make this flow work with OsuTouchInputMapper)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot play osu! with pen + touch input
1 participant