Package maintenance, prepare encryption and dart2wasm support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
reviewed
Jan 27, 2025
stevensJourney
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I've moved the
analysis_options.yamlfile down to the individual packages (I didn't get analysis errors otherwise) and I've fixed our code to be compliant with rules frompackage:lints. I've also removed thedclidev-dependency which was preventing us from upgrading some transitive dependencies. To find a temporary directory for native Dart tests, I've migrated to test_descriptor which is kind of the standard Dart package for that (and avoids importing implementation details of thetestpackage).In the pending version of
sqlite3_web, I've added an additional parameter to the database controller when opening databases. It allows clients with a custom controller to send custom options. We'll be able to use that inpowersync_sqlcipherto change the open procedure so that the wrappingmultipleciphers-$vfsVFS is used instead of the original Dart$vfswhen encryption is enabled.The new version of
sqlite3_webwill also use a new serialization format for statement parameters and result sets that is more efficient thanjsify()/dartify()(but it is backwards-compatible with that, we can upgrade with existing workers). It also unblocksdart2wasmsupport.