Use busy_timeout for better lock handling across Isolates #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While read statements can execute concurrently on multiple connections, write statements and transactions use an exclusive lock. Currently, a global database-level lock is maintained and exposed across isolates, but this requires explicitly passing an IsolateConnectionFactory across Isolates. This is fine when explicitly spawning a new Isolate to do background work from the main Isolate, but does not work when the Isolates are managed externally, for example when using flutter_workmanager.
This configures SQLite busy_timeout to 30 seconds to work around the issue. When another connection is locking the database, SQLite will retry until the timeout has been reached.
In principle that makes our own global mutex redundant, and removing it can give some performance gains. That will form a separate PR - see #35.