Opfs uploads #505
Merged
Opfs uploads #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c526bb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
commented
Feb 20, 2025
stevensJourney
commented
Feb 20, 2025
Chriztiaan
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A bug was identified when using OPFS as the SQLite VFS. When reconnecting with different client parameters, the PowerSync client failed to trigger CRUD uploads, preventing data from being uploaded. This issue occurred only when multiple tab support was enabled (the default).
The root cause was the shared sync worker using a stale database connection after a reconnect. The sync manager's logic for obtaining a database connection has been updated to ensure a valid connection is always used when a client disconnects or reconnects.
Relevant unit tests were updated to include OPFS.