Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1876] Playground - ERB Syntax Highlighting #4312

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[PLAY-1876] Playground - ERB Syntax Highlighting #4312

wants to merge 7 commits into from

Conversation

gabbymassaro
Copy link
Contributor

@gabbymassaro gabbymassaro commented Feb 24, 2025 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.
Enhance syntax highlighting accuracy

  • example <% end %> : create an new prism token to use the same highlighting as 'do' (has token of 'keyword')

Fix keyword color inconsistencies

  • regular text is too dark : create custom css to make the text white instead
  • Reduce font size to 12px

Screenshots: Screenshots to visualize your addition/change
Screenshot 2025-02-24 at 4 44 05 PM

How to test? Steps to confirm the desired behavior:

  1. Go to playbook.powerapp.cloud/kit_playground_rails
  2. add different kits to see the changes ( ex: Highlight Cards )
  3. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gabbymassaro gabbymassaro added enhancement New Features, Props, & Variants (USED IN CHANGELOG) minor Semver Target labels Feb 24, 2025
@gabbymassaro gabbymassaro self-assigned this Feb 24, 2025
@gabbymassaro gabbymassaro requested a review from a team as a code owner February 24, 2025 21:38
@gabbymassaro gabbymassaro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 24, 2025
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin Inactive RC Skip the release candidate process labels Feb 25, 2025
@gabbymassaro gabbymassaro removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

Assignees

@gabbymassaro gabbymassaro

Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process minor Semver Target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabbymassaro @nidaqg