Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-500] Currency Kit: Handling of null values #4303

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Feb 21, 2025

This PR adds a nullDisplay and null_display prop. The user can now choose how they want to display null value.

Screenshot 2025-02-24 at 11 33 21 AM

How to test? Steps to confirm the desired behavior:

  1. Go to Currency kit
  2. Scroll to last doc example

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Feb 21, 2025
@nickamantia nickamantia added minor Semver Target enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Feb 21, 2025
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.14.0.pre.alpha.pbntr500currencykithandlingofnullvalues6275

Your Alpha for NPM is 14.14.0-alpha.pbntr500currencykithandlingofnullvalues6275

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 24, 2025
@nickamantia nickamantia marked this pull request as ready for review February 24, 2025 16:48
@nickamantia nickamantia requested a review from a team as a code owner February 24, 2025 16:48
@nidaqg
Copy link
Contributor

nidaqg commented Feb 24, 2025

General question @nickamantia , do you think we need to account for emphasized, light and bold variants? If they are using this null as a value within a table, my assumption is they would want consistency in the display, so if the rest of the values are light, they'll want this to be light as well?

We can also always only account for whatever the default is for this kit and add follow ups to account for different variants. I would also reach out to a designer with these questions!

@nickamantia
Copy link
Contributor Author

nickamantia commented Feb 24, 2025

General question @nickamantia , do you think we need to account for emphasized, light and bold variants? If they are using this null as a value within a table, my assumption is they would want consistency in the display, so if the rest of the values are light, they'll want this to be light as well?

We can also always only account for whatever the default is for this kit and add follow ups to account for different variants. I would also reach out to a designer with these questions!

I 100% think we should make sure this works with all variants. That is an excellent point.

@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Feb 25, 2025
@nickamantia nickamantia added alpha and removed alpha labels Feb 25, 2025
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.14.0.pre.alpha.pbntr500currencykithandlingofnullvalues6311

Your Alpha for NPM is 14.14.0-alpha.pbntr500currencykithandlingofnullvalues6311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants