-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-500] Currency Kit: Handling of null
values
#4303
base: master
Are you sure you want to change the base?
[PBNTR-500] Currency Kit: Handling of null
values
#4303
Conversation
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.14.0.pre.alpha.pbntr500currencykithandlingofnullvalues6275 Your Alpha for NPM is 14.14.0-alpha.pbntr500currencykithandlingofnullvalues6275 |
General question @nickamantia , do you think we need to account for emphasized, light and bold variants? If they are using this null as a value within a table, my assumption is they would want consistency in the display, so if the rest of the values are light, they'll want this to be light as well? We can also always only account for whatever the default is for this kit and add follow ups to account for different variants. I would also reach out to a designer with these questions! |
I 100% think we should make sure this works with all variants. That is an excellent point. |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.14.0.pre.alpha.pbntr500currencykithandlingofnullvalues6311 Your Alpha for NPM is 14.14.0-alpha.pbntr500currencykithandlingofnullvalues6311 |
This PR adds a
nullDisplay
andnull_display
prop. The user can now choose how they want to display null value.How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.