[PLAY-1633] Display Title #4242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriyivanenko
commented
Feb 6, 2025
| 128px | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Dynamic classes attempt to simulate % of screen. They don't work as intended. Could be replaced with sm, md, lg if we go this route.
yuriyivanenko
added
enhancement
jasperfurniss
removed
the
milano
yuriyivanenko
added
the
milano
yuriyivanenko
added
milano
yuriyivanenko
added
milano
yuriyivanenko
added
milano
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1633-display-title |
nidaqg
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Story
This PR adds a "display" option for the existing size prop. It also adds a new
displaySizeprop for creating dynamically responsive titles at various sizes. We are still deciding whether to keepdisplaySizeor not.Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.