Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): expose prometheus metrics port for scraping if enabled #919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helm): expose prometheus metrics port for scraping if enabled #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/pgcat/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ maintainers:
- name: PostgresML
email: [email protected]
appVersion: "1.3.0"
version: 0.2.5
version: 0.2.6
9 changes: 9 additions & 0 deletions charts/pgcat/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ metadata:
name: {{ include "pgcat.fullname" . }}
labels:
{{- include "pgcat.labels" . | nindent 4 }}
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
replicas: {{ .Values.replicaCount }}
selector:
Expand Down Expand Up @@ -36,6 +40,11 @@ spec:
- name: pgcat
containerPort: {{ .Values.configuration.general.port }}
protocol: TCP
{{- if .Values.configuration.general.enable_prometheus_exporter }}
- name: metrics
containerPort: {{ .Values.configuration.general.prometheus_exporter_port }}
protocol: TCP
Copy link
Author

@killzoner killzoner Mar 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used TCP here and not HTTP because i'm not sure how specific the setup has to be for HTTP and custom/cloud specific LoadBalancer
And also it works as is so I don't think it's worth making things more complicated

https://kubernetes.io/docs/reference/networking/service-protocols/#protocol-http-special

{{- end }}
livenessProbe:
tcpSocket:
port: pgcat
Expand Down