Adjust direction of dropdowns at the bottom of the page #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Jan 18, 2025
media/commitfest/css/commitfest.css
Outdated
| @@ -37,7 +37,10 @@ div.form-group div.controls input.threadpick-input { | |||
| display: inline; | |||
| } | |||
|
|
|||
|
|
|||
| .dropdown-menu--up { | |||
There was a problem hiding this comment.
Instead of creating a custom class, it seems you can use the dropup class that's built into bootstrap instead (it's already used in commitfest.html). That also makes the caret point up. Other than that I think it's good the dropdown_mode thing seems to work well to isolate this to only the bottom of the page.
There was a problem hiding this comment.
Ah, that's very nice! Updated.
JelteF
reviewed
Jan 18, 2025
| @@ -183,7 +183,9 @@ <h4>Annotations</h4> | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| {% with dropdown_mode="dropup" %} | |||
There was a problem hiding this comment.
After sleeping on this, I think if you make this a <div class="dropup"> you get the same effect without having to change patch_commands.inc at all.
There was a problem hiding this comment.
Ha, that works! Very clean. :)
JelteF
pushed a commit
that referenced
this pull request
Jan 20, 2025
The bottom dropdowns on the patch page would expand downwards, requiring the user to scroll down to see and click any of the buttons in the dropdown. With this change these are changed into "dropup" menus, so the expand upwards.
JelteF
pushed a commit
that referenced
this pull request
Jan 20, 2025
The bottom dropdowns on the patch page would expand downwards, requiring the user to scroll down to see and click any of the buttons in the dropdown. With this change these are changed into "dropup" menus, so the expand upwards.
JelteF
pushed a commit
that referenced
this pull request
Feb 16, 2025
The bottom dropdowns on the patch page would expand downwards, requiring the user to scroll down to see and click any of the buttons in the dropdown. With this change these are changed into "dropup" menus, so the expand upwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revision of #2, which I'm reopening due to some messy merge history (master contains some force-pushes including files I also touch here.) The adjustment is to pass in a Django template variable to control when we want dropdowns to open "up".
At the bottom of the page:
At the top of the page:
It would still be nice to do this via a bootstrap upgrade and have the dropdown direction determined dynamically, but I think this is still just small enough of a change that it's worth it.