Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Prevent unintended duplication of exited session #7022

Merged
merged 10 commits into from
Mar 28, 2025

Conversation

samclark2015
Copy link
Contributor

@samclark2015 samclark2015 commented Mar 27, 2025

RuntimeSessionService now queries exited runtimes when invoking the selectRuntime method in multisession mode. This prevents starting a secondary copy when the positron-python extension updates interpreters.

Addresses #7005:

Screen.Recording.2025-03-27.at.2.18.53.PM.mov

selectRuntime only updates foreground session if a different runtime is chosen than the existing foreground session is using.

Addresses #6997:

Screen.Recording.2025-03-27.at.2.29.36.PM.mov

Release Notes

New Features

  • N/A

Bug Fixes

  • No duplicate of an exited session is created when it becomes the foreground session.
  • Console does not switch to last-created session for a runtime when interpreter updated by positron-python.

QA Notes

e2e: @:sessions @:console

@samclark2015 samclark2015 requested review from seeM and midleman March 27, 2025 19:21
Copy link

github-actions bot commented Mar 27, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:sessions @:console

readme  valid tags

Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the e2e test failures related to changes in this PR?

Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samclark2015 samclark2015 merged commit 4a1b593 into main Mar 28, 2025
8 checks passed
@samclark2015 samclark2015 deleted the fix/python-switch-exited-interpreter branch March 28, 2025 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants