Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections: Support for custom icons #6282

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Connections: Support for custom icons #6282

merged 7 commits into from
Feb 11, 2025

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Feb 11, 2025

Addresses #6187

Add support for custom icons in the new connections pane.
The connections contract allows connections to provide a custom icon, which should be a full path to a squared png file.

CleanShot 2025-02-11 at 11 11 06@2x

This PR adds support for those icons in a few different places:

CleanShot 2025-02-11 at 11 12 34@2x

CleanShot 2025-02-11 at 11 12 44@2x

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

Not many packages support custom icons. I think the easiest setup is to use bigrquery:

library(DBI)

con <- dbConnect(
  bigrquery::bigquery(),
  project = "publicdata",
  dataset = "samples",
  billing = "gcp-project-id"
)

Where billing is a GCP project id.

HEre's another snippet that might be useful for reproducing:

install.packages("FactoMineR")
remotes::install_github("ColinFay/fryingpane")

library(fryingpane)
cook("FactoMineR")

@:connections

Copy link

github-actions bot commented Feb 11, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:connections

readme  valid tags

@dfalbel dfalbel requested a review from softwarenerd February 11, 2025 15:46
softwarenerd
softwarenerd previously approved these changes Feb 11, 2025
Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And, as we discussed on Zoom, I'd recommend moving any styles like:

<div className='col-icon' style={{ width: `${26}px` }}>
{icon ? <img src={icon} style={{ width: '26px', height: '26px' }}></img>

That are not being calculated in the .tsx file into the .css file for the component.

Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@dfalbel dfalbel merged commit 2db004b into main Feb 11, 2025
8 checks passed
@dfalbel dfalbel deleted the connections/icons branch February 11, 2025 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants