Skip to content

Commit

Permalink
Reverse order of updating the information pane: 1st content, 2nd toolbar
Browse files Browse the repository at this point in the history
When the toolbar buttons are updated first, the adjust range method in
the chart within the pane content initially receives an incorrect pixel#
width.

Issue: #3969
  • Loading branch information
buchen committed May 9, 2024
1 parent 16d4581 commit daa688b
Showing 1 changed file with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -184,21 +184,19 @@ private void selectPage(InformationPanePage page, DropDown dropdown)
return c;
});

// update toolbar with pane controls
// important: refresh input when showing the page b/c pages
// currently not visible are not updated if data changes
page.setInput(currentInput);
pagebook.showPage(control);

// update toolbar with pane controls
if (!toolBarPaneControls.getControl().isDisposed())
{
toolBarPaneControls.removeAll();
page.addButtons(toolBarPaneControls);
toolBarPaneControls.update(true);
}

// important: refresh input when showing the page b/c pages
// currently not visible are not updated if data changes

page.setInput(currentInput);
pagebook.showPage(control);

for (IContributionItem item : toolBarPaneSelection.getItems())
{
if (item == dropdown)
Expand Down

0 comments on commit daa688b

Please sign in to comment.