Refactored duplicate methods into ArraysUtil helper class

Issue: #3969
portfolio-performance · May 9, 2024 · d583378 · d583378
1 parent bfaa3d9
commit d583378
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 40 deletions.
diff --git a/name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/PortfolioBalanceChart.java b/name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/PortfolioBalanceChart.java
@@ -1,5 +1,8 @@
 package name.abuchen.portfolio.ui.views;
 
+import static name.abuchen.portfolio.util.ArraysUtil.accumulateAndToDouble;
+import static name.abuchen.portfolio.util.ArraysUtil.toDouble;
+
 import java.time.LocalDate;
 import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
@@ -274,26 +277,6 @@ private void addFees(PerformanceIndex index, int swtAntialias)
         lineSeries.setAntialias(swtAntialias);
     }
 
-    private double[] toDouble(long[] input, double divider)
-    {
-        double[] answer = new double[input.length];
-        for (int ii = 0; ii < answer.length; ii++)
-            answer[ii] = input[ii] / divider;
-        return answer;
-    }
-
-    private double[] accumulateAndToDouble(long[] input, double divider)
-    {
-        double[] answer = new double[input.length];
-        long current = 0;
-        for (int ii = 0; ii < answer.length; ii++)
-        {
-            current += input[ii];
-            answer[ii] = current / divider;
-        }
-        return answer;
-    }
-
     private enum ChartDetails
     {
         ABSOLUTE_INVESTED_CAPITAL(Messages.LabelAbsoluteInvestedCapital), //

diff --git a/...lio.ui/src/name/abuchen/portfolio/ui/views/dataseries/StatementOfAssetsSeriesBuilder.java b/...lio.ui/src/name/abuchen/portfolio/ui/views/dataseries/StatementOfAssetsSeriesBuilder.java
@@ -1,5 +1,8 @@
 package name.abuchen.portfolio.ui.views.dataseries;
 
+import static name.abuchen.portfolio.util.ArraysUtil.accumulateAndToDouble;
+import static name.abuchen.portfolio.util.ArraysUtil.toDouble;
+
 import org.swtchart.IBarSeries;
 import org.swtchart.ILineSeries;
 
@@ -125,24 +128,4 @@ private long[] add(long[] a, long[] b)
 
         return result;
     }
-
-    private double[] toDouble(long[] input, double divider)
-    {
-        double[] answer = new double[input.length];
-        for (int ii = 0; ii < answer.length; ii++)
-            answer[ii] = input[ii] / divider;
-        return answer;
-    }
-
-    private double[] accumulateAndToDouble(long[] input, double divider)
-    {
-        double[] answer = new double[input.length];
-        long current = 0;
-        for (int ii = 0; ii < answer.length; ii++)
-        {
-            current += input[ii];
-            answer[ii] = current / divider;
-        }
-        return answer;
-    }
 }
diff --git a/name.abuchen.portfolio/src/name/abuchen/portfolio/util/ArraysUtil.java b/name.abuchen.portfolio/src/name/abuchen/portfolio/util/ArraysUtil.java
@@ -0,0 +1,29 @@
+package name.abuchen.portfolio.util;
+
+public class ArraysUtil
+{
+    private ArraysUtil()
+    {
+    }
+
+    public static double[] toDouble(long[] input, double divider)
+    {
+        double[] answer = new double[input.length];
+        for (int ii = 0; ii < answer.length; ii++)
+            answer[ii] = input[ii] / divider;
+        return answer;
+    }
+
+    public static double[] accumulateAndToDouble(long[] input, double divider)
+    {
+        double[] answer = new double[input.length];
+        long current = 0;
+        for (int ii = 0; ii < answer.length; ii++)
+        {
+            current += input[ii];
+            answer[ii] = current / divider;
+        }
+        return answer;
+    }
+
+}