socket: set ipv6 preference to false #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch relies on explicitly setting the address family to AF_INET6 by default when using `getaddrinfo`. This results in ENONAME on systems which do not have IPv6 available, as is the case within EKS in our setup. The correct behavior should be to set the family to AF_UNSPEC, and if necessary to rely on `gai.conf` to set precedence to control which address is returned first. This will be addressed separately by raising a PR upstream. In the interval, our fork should default to IPv4 to allow host lookups to work as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch relies on explicitly setting the address family to AF_INET6 by default when using
getaddrinfo. This results in ENONAME on systems which do not have IPv6 available, as is the case within EKS in our setup.The correct behavior should be to set the family to AF_UNSPEC, and if necessary to rely on
gai.confto set precedence to control which address is returned first. This will be addressed separately by raising a PR upstream.In the interval, our fork should default to IPv4 to allow host lookups to work as intended.
Fixes #ISSUE_NUMBER