Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont hardcode path to config.h #465

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dont hardcode path to config.h #465

wants to merge 2 commits into from
+3 −3

Conversation

notpeelz
Copy link
Contributor

Split from #454 as requested.

This is a minor change that requires meson >= 1.4.0, which isn't available in Fedora 39.
F39 becomes EOL on 2024-11-12.

@notpeelz notpeelz mentioned this pull request Jun 26, 2024
Merged
@vmihalko
Copy link
Collaborator

vmihalko commented Feb 6, 2025

Could you please resolve the conflicts? Then, we can proceed with the merge.

@notpeelz notpeelz force-pushed the dont-hardcode-path-config-h branch from 2a3d57a to 8ab85eb Compare February 6, 2025 14:10
@notpeelz
Copy link
Contributor Author

notpeelz commented Feb 6, 2025 •
edited
Loading

Done

CI doesn't have meson 1.4.0 yet. Is that a problem?

@notpeelz notpeelz changed the title Dont hardcode path config.h Dont hardcode path to config.h Feb 6, 2025
@jrybar-rh
Copy link
Member

Done

CI doesn't have meson 1.4.0 yet. Is that a problem?

@mrc0mmand: ^

@mrc0mmand
Copy link
Member

mrc0mmand commented Feb 6, 2025 •
edited
Loading

Hmpf, this is quite a big meson version bump and it cuts off some currently still supported distributions, most importantly Ubuntu Noble (24.04, LTS) - released in Apr 2024, supported until Apr 2029, currently has meson 1.3.2, so I'm still not sure if it's worth it.

As I said in #454 (comment) you don't really have to use full path to the config.h file (IIUC; it works that way fine in systemd), which would drop the requirement for the version bump.

@notpeelz
Copy link
Contributor Author

notpeelz commented Feb 6, 2025

Ah... gotta love eternally-outdated distros.

Feel free to close this PR if you don't think it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notpeelz @vmihalko @jrybar-rh @mrc0mmand