feat: Improve how values are validated in filter utils #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `createEqFilter` will now accept 0 or false, for example. Will refuse
actually undefined values.
Found this when trying to use `createGtFilter('...', 0)` and my filter
wouldn't be applied.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jm42
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
createEqFilterwill now accept 0 or false, for example. Will refuse actually undefined values.createBoolFilteras it's the same ascreateEqFilter. (I'm open to different opinions on this, we could deprecate or keep it).Found this when trying to use
createGtFilter('...', 0)and my filter wouldn't be applied.Type of change
Checklist