Fixes bug with redirectUris option not required for platforms. Closes #6565

docs/docs/cmd/entra/app/app-add.mdx

@@ -31,7 +31,7 @@ m365 entra appregistration add [options]
 : Comma-separated list of redirect URIs. Requires `platform` to be specified.
 
 `-p, --platform [platform]`
-: Platform for which the `redirectUris` should be configured. Allowed values `spa`, `web`, `publicClient`.
+: Platform for which the `redirectUris` should be configured. Allowed values `spa`, `web`, `publicClient`. Requires `redirectUris` to be specified.
 
 `--implicitFlow`
 : Specify, to indicate that the authorization endpoint should return ID and access tokens.

src/m365/entra/commands/app/app-add.spec.ts

@@ -6386,17 +6386,17 @@ describe(commands.APP_ADD, () => {
   });
 
   it('passes validation if platform value is spa', async () => {
-    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'spa' } }, commandInfo);
+    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'spa', redirectUris: 'http://localhost:8080' } }, commandInfo);
     assert.strictEqual(actual, true);
   });
 
   it('passes validation if platform value is web', async () => {
-    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'web' } }, commandInfo);
+    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'web', redirectUris: 'http://localhost:8080' } }, commandInfo);
     assert.strictEqual(actual, true);
   });
 
   it('passes validation if platform value is publicClient', async () => {
-    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'publicClient' } }, commandInfo);
+    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'publicClient', redirectUris: 'http://localhost:8080' } }, commandInfo);
     assert.strictEqual(actual, true);
   });
 
@@ -6410,6 +6410,21 @@ describe(commands.APP_ADD, () => {
     assert.strictEqual(actual, true);
   });
 
+  it('fails validation if platform is spa and redirectUris is not specified', async () => {
+    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'spa' } }, commandInfo);
+    assert.notStrictEqual(actual, true);
+  });
+
+  it('fails validation if platform is web and redirectUris is not specified', async () => {
+    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'web' } }, commandInfo);
+    assert.notStrictEqual(actual, true);
+  });
+
+  it('fails validation if platform is publicClient and redirectUris is not specified', async () => {
+    const actual = await command.validate({ options: { name: 'My Microsoft Entra app', platform: 'publicClient' } }, commandInfo);
+    assert.notStrictEqual(actual, true);
+  });
+
   it('fails validation if scopeName specified without uri', async () => {
     const actual = await command.validate({ options: { name: 'My Microsoft Entra app', scopeName: 'access_as_user', scopeAdminConsentDescription: 'Access as user', scopeAdminConsentDisplayName: 'Access as user' } }, commandInfo);
     assert.notStrictEqual(actual, true);

src/m365/entra/commands/app/app-add.ts

@@ -151,6 +151,10 @@ class EntraAppAddCommand extends GraphCommand {
           return `When you specify redirectUris you also need to specify platform`;
         }
 
+        if (args.options.platform && ['spa', 'web', 'publicClient'].indexOf(args.options.platform) > -1 && !args.options.redirectUris) {
+          return `When you use platform spa, web or publicClient, you'll need to specify redirectUris`;
+        }
+
         if (args.options.certificateFile && args.options.certificateBase64Encoded) {
           return 'Specify either certificateFile or certificateBase64Encoded but not both';
         }