-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rds/kjw/function get more stringent surface conditioning category #1644
Open
KarenWGard
wants to merge
27
commits into
feature/ashrae-9012022
Choose a base branch
from
RDS/KJW/function_get_more_stringent_surface_conditioning_category
base: feature/ashrae-9012022
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
63c4f6d
Create get_more_stringent_surface_conditioning_category.md
KarenWGard 39a2308
Update Rule5-10.md
KarenWGard d7b3050
Update Rule5-11.md
KarenWGard ce2b077
Update Rule5-12.md
KarenWGard 2733489
Update Rule5-13.md
KarenWGard 550818d
Update Rule5-16.md
KarenWGard 91c0224
Update Rule5-19.md
KarenWGard 1a821e7
Update Rule5-20.md
KarenWGard 06eef19
Update Rule5-21.md
KarenWGard 872e0e6
Update Rule5-22.md
KarenWGard 54aed41
Update Rule5-26.md
KarenWGard 635b091
Update Rule5-27.md
KarenWGard 3b4ad88
Update Rule5-28.md
KarenWGard 309ef6e
Update Rule5-29.md
KarenWGard 93ebe50
Update Rule5-3.md
KarenWGard 6b77d0c
Update Rule5-31.md
KarenWGard 5e441c1
Update Rule5-35.md
KarenWGard e7ddcb9
Update Rule5-37.md
KarenWGard f02e100
Update Rule5-39.md
KarenWGard 244b0fb
Update Rule5-4.md
KarenWGard 323d018
Update Rule5-40.md
KarenWGard 47a32b4
Update Rule5-5.md
KarenWGard 66e1afe
Update Rule5-6.md
KarenWGard 54ac253
Update Rule5-7.md
KarenWGard 7b92fee
Update Rule5-8.md
KarenWGard 09987f1
Update Rule5-9.md
KarenWGard ff2b349
Update Rule5-37.md
KarenWGard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
docs/ruleset_functions/get_more_stringent_surface_conditioning_category.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
|
||
## get_more_stringent_surface_conditioning_category | ||
**Schema Version:** 0.0.39 | ||
Description: This function relies on get_surface_conditioning_category to return a dictionary that provides the more stringent conditioning category between the proposed and baseline RMDs. This rule is written to ensure that the surface conditioning categories comply with the following: | ||
"Space conditioning categories used to determine applicability of the envelope requirements in Tables G3.4-1 through G3.4-8 shall be the same as in the proposed design. | ||
|
||
Exception: Envelope components of the HVAC zones that are semiheated in the proposed design must meet conditioned envelope requirements in Tables G3.4-1 through G3.4-8 if, based on the sizing runs, these zones are served by a baseline system with sensible cooling output capacity >= 5 Btu/h·ft2 of floor area, or with heating output capacity greater than or equal to the criteria in Table G3.4-9, or that are indirectly conditioned spaces." | ||
|
||
|
||
Inputs: | ||
|
||
- **B_RMD**: The baseline RMD used to determine surface conditioning category. | ||
- **P_RMD**: The proposed RMD used to determine surface conditioning category. | ||
|
||
Functions: | ||
- **get_surface_conditioning_category** | ||
|
||
Returns: | ||
|
||
- **surface_conditioning_category**: The Surface Conditioning Category [exterior residential, exterior non-residential, exterior mixed, semi-exterior, unregulated]. | ||
|
||
Logic: | ||
|
||
- Get the surface conditioning category dictionary for the B_RMD: `b_surface_conditioning_category = get_surface_conditioning_category(B_RMD)` | ||
|
||
- Get the surface conditioning category dictionary for the P_RMD: `p_surface_conditioning_category = get_surface_conditioning_category(P_RMD)` | ||
|
||
- Create a new surface conditioning category dictionary that will be a combination of the two: `surface_conditioning_category = {}` | ||
|
||
- Look at each surface id in the baseline RMD: `for surface_id in b_surface_conditioning_category:` | ||
|
||
- Check to see if the two conditioning cateogries match: `if b_surface_conditioning_category[surface_id] == p_surface_conditioning_category[surface_id]:` | ||
|
||
- then this category is the category to be used. Add this category to surface_conditioning_category: `surface_conditioning_category[surface_id] = b_surface_conditioning_category[surface_id]` | ||
|
||
- Otherwise, if the proposed is semi-exterior, and the baseline is one of [exterior residential, exterior non-residential, exterior mixed], then the conditioning category needs to be the more stringent: `if b_surface_conditioning_category[surface_id] in ["exterior residential", "exterior non-residential", "exterior mixed"] and p_surface_conditioning_category[surface_id] == "semi-exterior": surface_conditioning_category[surface_id] = b_surface_conditioning_category[surface_id]` | ||
|
||
- All other cases, set the conditioning category equal to that in the proposed: `surface_conditioning_category[surface_id] = p_surface_conditioning_category[surface_id]` | ||
|
||
**Returns** `return surface_conditioning_category_dict` | ||
|
||
**Notes** | ||
1. What if the proposed is "unregulated" and the baseline is a different category? | ||
|
||
**[Back](../_toc.md)** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prob upgrade schema version to the latest schema version.