RS/JDJ/final renumbering #1604
Open
RS/JDJ/final renumbering #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonJ-KC
commented
Jan 16, 2025
JacksonJ-KC
commented
Jan 16, 2025
JacksonJ-KC
commented
Jan 16, 2025
| class Section1Rule1(RuleDefinitionListIndexedBase): | ||
| """Rule 1 of ASHRAE 90.1-2019 Appendix G Section 1 (Performance Calculations)""" | ||
| class PRM9012019Rule73j65(RuleDefinitionListIndexedBase): | ||
| """Rule 73j65 of ASHRAE 90.1-2019 Appendix G""" |
There was a problem hiding this comment.
@weilixu I was not able to automate updating these docstrings
JacksonJ-KC
commented
Jan 16, 2025
| @@ -21,6 +21,215 @@ | |||
| "section23", | |||
| ] | |||
|
|
|||
| rules_dict = { | |||
There was a problem hiding this comment.
rule number map is here FYI
weilixu
reviewed
Jan 16, 2025
# Conflicts: # rct229/rulesets/ashrae9012019/section1/section1rule1.py # rct229/rulesets/ashrae9012019/section1/section1rule5.py # rct229/rulesets/ashrae9012019/section1/section1rule6.py # rct229/rulesets/ashrae9012019/section1/section1rule7.py # rct229/rulesets/ashrae9012019/section11/section11rule1.py # rct229/rulesets/ashrae9012019/section11/section11rule10.py # rct229/rulesets/ashrae9012019/section11/section11rule13.py # rct229/rulesets/ashrae9012019/section11/section11rule16.py # rct229/rulesets/ashrae9012019/section11/section11rule8.py # rct229/rulesets/ashrae9012019/section19/section19rule15.py # rct229/rulesets/ashrae9012019/section19/section19rule19.py # rct229/rulesets/ashrae9012019/section19/section19rule35.py # rct229/rulesets/ashrae9012019/section19/section19rule7.py # rct229/rulesets/ashrae9012019/section21/section21rule1.py # rct229/rulesets/ashrae9012019/section21/section21rule2.py # rct229/rulesets/ashrae9012019/section22/section22rule17.py # rct229/rulesets/ashrae9012019/section22/section22rule35.py # rct229/rulesets/ashrae9012019/section22/section22rule37.py # rct229/rulesets/ashrae9012019/section22/section22rule38.py # rct229/rulesets/ashrae9012019/section22/section22rule39.py # rct229/rulesets/ashrae9012019/section23/section23rule1.py # rct229/rulesets/ashrae9012019/section4/section4rule1.py # rct229/rulesets/ashrae9012019/section4/section4rule11.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weilixu and @jugonzal07 This is ready for review! The renumbering script is counting on the master ruletest json files to still exist in the repo and it is also expecting them to have been regenerated from the spreadsheets according to the new naming convention. Running it with the current master json files will result in a ValueError.