Feat: React 19 Upgrade #2363
Open
Feat: React 19 Upgrade #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Bumped deps and refactored usages of forwardRef
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closing #2341
What
Main changes:
forwardRef- As per the React docs, will be fully deprecated in future.reffields with the valid React Types - Any polymorphic components were set asanyfor theRefObjectgeneric.useRefwhich were missing inits.SpringContextto resemble a more sensible Context structureChecklist
reffieldsuseRefAdditional Comments
This was based on this PR: #2349
As the PR and issue have been open for a good while now, it's obvious that no further development was going to happen - I'm currently blocked by this library, so I thought it'd try and help with moving this forward.
PR Diff
I'm unsure as to why the diff is heavily focused on formatting changes - I was sure to run prettier via the NPM script before submitting this PR. Happy to outline all the direct code changes if necessary.