Block: (Walls) implement tall/short connections #6624
+114
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
requested changes
Feb 13, 2025
| if($up !== $this->post){ | ||
| $this->post = $up; | ||
| $changed++; | ||
| } |
There was a problem hiding this comment.
This is going to break things. Post should be set for the ends of walls.
src/block/Wall.php
Outdated
| foreach(Facing::HORIZONTAL as $facing){ | ||
| $block = $this->getSide($facing); | ||
| if($block instanceof static || $block instanceof FenceGate || $block instanceof Thin || $block->getSupportType(Facing::opposite($facing)) === SupportType::FULL){ | ||
| if(!isset($this->connections[$facing])){ | ||
| $this->connections[$facing] = WallConnectionType::SHORT; | ||
| if($this->getSide(Facing::UP)->getTypeId() == BlockTypeIds::AIR) { |
There was a problem hiding this comment.
Suggested change
| if($this->getSide(Facing::UP)->getTypeId() == BlockTypeIds::AIR) { | |
| if($this->getSide(Facing::UP)->getTypeId() === BlockTypeIds::AIR){ |
I'm also fairly sure the logic for this is more complex than just checking for air.
There was a problem hiding this comment.
Ill do some more testing but I haven't found any issues yet.
There was a problem hiding this comment.
Yeah gonna have to add more logic, this isn't the indented state
There was a problem hiding this comment.
Defiantly issues, will continue testing and implementing more logic for vertical connections
dktapps
added
Category: Gameplay
|
just a visual test |
|
Yeah i'm working on it now, i'm implementing the logic from dragonfly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues & PRs
Behavioural changes
Changed how walls behave with block on top of them.
Tests