Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #131 and #162 resolved #167

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

MrTeale
Copy link

@MrTeale MrTeale commented Mar 30, 2022

  1. Issue use _imports_ not load_components #131: removed _dash.development.component_loader.load_components and utilised ._imports_ as seen in dash-bio

  2. Issue Next release/best way of using last version #162: ._imports_ fix from use _imports_ not load_components #131 allows for installs via:

pip install git+https://github.com/plotly/dash-daq.git#egg=dash_daq
# or until merged, use:
pip install git+https://github.com/mrteale/dash-daq.git@fix/131-imports#egg=dash_daq

@MrTeale
Copy link
Author

MrTeale commented Mar 30, 2022

Fixes #69

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @MrTeale - I didn't realize dash-daq was still using the old load_components, definitely time to upgrade!

Merging now, unfortunately it still may be a little while before we're able to release this as there are a whole bunch of changes made in the fall and winter that we haven't had a chance to QA. We'll try to get to it soon but I can't say when.

@alexcjohnson alexcjohnson merged commit f543235 into plotly:master Apr 6, 2022
@MrTeale MrTeale deleted the fix/131-imports branch April 6, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants