Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the content for the Diazo theming part #1870

Merged
merged 28 commits into from
Feb 26, 2025

Conversation

erral
Copy link
Member

@erral erral commented Feb 20, 2025

Can be seen as part of #1645


📚 Documentation preview 📚: https://plone6--1870.org.readthedocs.build/

@erral erral changed the base branch from 6.0 to classic-ui-theming-reorg-1645 February 20, 2025 11:26
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restructured the Diazo doc to present the critical path first, followed by advice. It flows a little better, but there are still some issues with it, namely a first-timer would have no clue what to do after reading this.

erral and others added 5 commits February 24, 2025 15:24
explain the purpose of each file created when addin a theme
Link to Diazo docs.
- Reuse a sentence from Diazo docs that fills a critical gap in the introduction.
- Convert list of files descriptions into a definition list
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! A couple of questions regarding the registry.xml file for TinyMCE.

@stevepiercy
Copy link
Contributor

The failing test is a linkcheck failure that is fixed in the related PR. Merging! 🎉 Thanks @erral for all the work, and @petschki for the assist!

@stevepiercy stevepiercy merged commit 9747612 into classic-ui-theming-reorg-1645 Feb 26, 2025
2 of 3 checks passed
@stevepiercy stevepiercy deleted the erral-diazo-docs branch February 26, 2025 09:52
stevepiercy added a commit that referenced this pull request Feb 26, 2025
* Reorganize Classic UI Theming part

* Update docs/classic-ui/theming/settings-ttw.md

Co-authored-by: Peter Mathis <[email protected]>

* Update settings-ttw.md

* Fix broken link

* Add guide for choosing one Classic UI theme or another, thanks to @jensens!

* Provide the content for the Diazo theming part (#1870)

* Update tips submodules/plone.api submodules/volto

* Update tip submodules/volto

* Fix broken references (#1868)

* Fix broken references
- `link.svg`
- `_inc/_install-browser-reqs-volto.md`

* Fix linkcheck to bobtemplates

* Update tip submodules/volto

* Fix link

* Update tip submodules/plone.api

* Update tip submodules/volto

* initial structure of Theming with Diazo

* more doc

* initial structure of Theming with Diazo

* more doc

* - Add diazo to toctree
- Add note update getting help for choosing a theming method

* Clean up grammar, one sentence per line, MyST syntax

* Add language

* Move concepts and advice into a new Theme development advice section

* Minor tweaks

* Rename section to reflect its content

* Adjust heading level

* Update diazo.md

explain the purpose of each file created when addin a theme

* Update diazo.md

Link to Diazo docs.

* Update diazo.md

* - Make first mention of Diazo a term, already existing in the Glossary
- Reuse a sentence from Diazo docs that fills a critical gap in the introduction.
- Convert list of files descriptions into a definition list

* Tweak markup

* add tinymce templates docs

* Tidy up

* Add a label and important admonition about Template plugin removal in TinyMCE 7.0

* Remove important admonition about Template plugin

---------

Co-authored-by: Steve Piercy <[email protected]>

* Fix broken link

---------

Co-authored-by: Peter Mathis <[email protected]>
Co-authored-by: Mikel Larreategi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants