update english translations #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
force-pushed
the
update_english_translations
branch
10 times, most recently
from
5661ba4
to
cf4241e
Compare
ruslandoga
force-pushed
the
update_english_translations
branch
2 times, most recently
from
88d61b9
to
98ab60f
Compare
ruslandoga
force-pushed
the
update_english_translations
branch
from
da5f1c3
to
835d849
Compare
ruslandoga
force-pushed
the
update_english_translations
branch
from
835d849
to
a594b7d
Compare
This was referenced Jul 10, 2024
Merged
ukutaht
reviewed
Jul 11, 2024
ukutaht
approved these changes
Jul 11, 2024
ruslandoga
commented
Jul 11, 2024
| @@ -123,6 +123,8 @@ defmodule Mix.Tasks.UpdateEnglishTranslations do | |||
| "KZ-75" => "Almaty City", | |||
| # https://en.wikipedia.org/wiki/ISO_3166-2:FI | |||
| "FI-01" => "Åland", | |||
| "FI-06" => "Kanta-Häme", | |||
| "FI-16" => "Päijät-Häme", | |||
There was a problem hiding this comment.
Overriding it from Päijänne Tavastia to Päijät-Häme because GPT says it's the more common name in both English and Finnish https://chatgpt.com/share/1c672980-68ff-4f92-ba92-869825d61d47 and also because the Wikipedia article is titled that way https://en.wikipedia.org/wiki/Päijät-Häme. Similar for Kanta-Häme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates English translations and starts using CLDR instead of scraping Wikipedia.