New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore self.log logger in BaseHandler #96

Merged

trungleduc merged 1 commit into plasmabio:master from TimoRoth:fix_logger

Feb 17, 2025

Contributor

TimoRoth commented Feb 17, 2025

This is analog to how it's implemented in jupyterhub itself: https://github.com/jupyterhub/jupyterhub/blob/main/jupyterhub/handlers/base.py#L118
Without this, I saw some exceptions in my logs trying to access the non-existent logger under Jupyterhub 5.


          Restore self.log logger in BaseHandler

trungleduc approved these changes

View reviewed changes

Member

trungleduc commented Feb 17, 2025

Thanks!

trungleduc merged commit 9457e39 into plasmabio:master

9 checks passed

trungleduc added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels