Style adjusting with JupyterHub 5 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The profile selection is too big
|
trungleduc
reviewed
Feb 17, 2025
|
@jtpio This PR fixes the style issues with JupyterHub 5 but it breaks the CSS of JupyterHub 4. What do you think? |
Looks like JupyterHub 5 was released on May 24, 2024. Which means there has been some time already for folks to upgrade, so it should likely be fine. Maybe this CSS change should be documented somewhere (or it will automatically by the releaser). And release this in a minor version of |
|
|
|
So let's merge it, I will address the documentation in another PR. |
trungleduc
approved these changes
Feb 17, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.
tljh.webm