Merge pull request #60 from plaidev/flutter-e2e

mv TipKit to weak frameworks
plaidev · Oct 11, 2024 · 12b1884 · 12b1884
2 parents e4c0ec2 + 376b081
commit 12b1884
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/Nativebrik.podspec b/Nativebrik.podspec
@@ -17,6 +17,10 @@ Nativebrik SDK for iOS.
 
   s.source_files = 'ios/Nativebrik/Nativebrik/**/*'
 
-  s.frameworks = 'UIKit', 'Foundation', 'SwiftUI', 'Combine', 'YogaKit', 'Yoga', 'TipKit', 'ImageIO', 'SafariServices'
+  # common deps
+  s.frameworks = 'UIKit', 'Foundation', 'SwiftUI', 'Combine', 'YogaKit', 'Yoga', 'ImageIO', 'SafariServices'
+
+  # >= ios 17.0
+  s.weak_frameworks = 'TipKit'
   s.dependency 'YogaKit', '~> 2.0.0'
 end
diff --git a/flutter/nativebrik_bridge/e2e/ios/Runner.xcodeproj/project.pbxproj b/flutter/nativebrik_bridge/e2e/ios/Runner.xcodeproj/project.pbxproj
@@ -161,7 +161,6 @@
 				B9C9C36511C3138F37154FA6 /* Pods-RunnerTests.release.xcconfig */,
 				97727B89B5181B32354A5E0C /* Pods-RunnerTests.profile.xcconfig */,
 			);
-			name = Pods;
 			path = Pods;
 			sourceTree = "<group>";
 		};
@@ -486,7 +485,7 @@
 				SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO;
 				SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
 				SWIFT_VERSION = 5.0;
-				TARGETED_DEVICE_FAMILY = "1,2";
+				TARGETED_DEVICE_FAMILY = 1;
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Profile;
@@ -675,7 +674,7 @@
 				SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 				SWIFT_VERSION = 5.0;
-				TARGETED_DEVICE_FAMILY = "1,2";
+				TARGETED_DEVICE_FAMILY = 1;
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Debug;
@@ -702,7 +701,7 @@
 				SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO;
 				SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h";
 				SWIFT_VERSION = 5.0;
-				TARGETED_DEVICE_FAMILY = "1,2";
+				TARGETED_DEVICE_FAMILY = 1;
 				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Release;