Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated contributing doc where env local had different domains #275

Conversation

ArshadChowdhury
Copy link
Contributor

@ArshadChowdhury ArshadChowdhury commented Oct 31, 2023

What does this PR do?

Fixes # (issue)

Updated Contributing.md file where it had only one public domain now we have two so had to update the doc accordingly.

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set? - NO
  • What are the minimal test data to have? - N/A
  • What is expected (happy path) to have (input and output)? - N/A
  • Any other important info that could help to test that PR - N/A

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
review-app ❌ Failed (Inspect) Oct 31, 2023 2:49pm

Copy link

github-actions bot commented Oct 31, 2023

Thank you for following the naming conventions! 🙏

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @ArshadChowdhury 😃,

Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.

@ArshadChowdhury ArshadChowdhury changed the title Fix: Updated contributing doc where env local had different domains fix: Updated contributing doc where env local had different domains Oct 31, 2023
@ArshadChowdhury ArshadChowdhury changed the title fix: Updated contributing doc where env local had different domains docs: Updated contributing doc where env local had different domains Oct 31, 2023
@hemantwasthere
Copy link
Collaborator

Already resolved!

@ArshadChowdhury
Copy link
Contributor Author

ArshadChowdhury commented Oct 31, 2023

@hemantwasthere bro the doc is not updated according to new env domain.

the previous & current version here is this -

NEXT_PUBLIC_AWS_API_URL=http://localhost:8000/local
NEXT_PUBLIC_APP_DASHBOARD_DOMAIN=app
NEXT_PUBLIC_APP_DOMAIN=localhost:3000

the new version should be this (in this pr) -

NEXT_PUBLIC_AWS_API_URL=
NEXT_PUBLIC_APP_DASHBOARD_DOMAIN=
NEXT_PUBLIC_APP_PUBLIC_DOMAIN=
NEXT_PUBLIC_APP_CUSTOM_DOMAIN=

Copy link
Collaborator

@hemantwasthere hemantwasthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hemantwasthere hemantwasthere merged commit c727251 into piyushgarg-dev:main Oct 31, 2023
9 of 12 checks passed
@ArshadChowdhury
Copy link
Contributor Author

Thank you very much, really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants