Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilemap indexbuffer can no longer be destroyed #172

Merged
merged 1 commit into from
Feb 2, 2025
Merged

tilemap indexbuffer can no longer be destroyed #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/TilemapPipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@
label: 'index-tilemap-buffer',
usage: BufferUsage.INDEX | BufferUsage.COPY_DST,
});
// Remove the destroy method from the index buffer to prevent it from being destroyed.

Check warning on line 74 in src/TilemapPipe.ts

View workflow job for this annotation

GitHub Actions / build 

Expected indentation of 8 spaces but found 2 tabs
// This is because the index buffer is shared between all tilemaps, and .destroy will be called when destroying a tilemap.

Check warning on line 75 in src/TilemapPipe.ts

View workflow job for this annotation

GitHub Actions / build 

This line has a length of 130. Maximum allowed is 125
this.indexBuffer.destroy = () => {};

this.checkIndexBuffer(2000);
}

Expand Down
Loading