Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users management #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Users management #20

wants to merge 1 commit into from

Conversation

hiderr
Copy link

@hiderr hiderr commented Jan 29, 2025 •
edited
Loading

image

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
canary ❌ Failed (Inspect) Jan 31, 2025 2:27pm

hiderr
hiderr commented Jan 29, 2025
View reviewed changes
.eslintrc.json Outdated
@@ -43,10 +43,9 @@
"import/no-unresolved": "off",
"react/prop-types": "off",
"react/react-in-jsx-scope": "off",

"tailwindcss/classnames-order": "off",
Copy link
Author

@hiderr hiderr Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Husky runs during a commit and executes the lint-staged operation across all packages, Prettier and ESLint conflict on this rule. Prettier already handles all types of sorting, as it has the 'prettier-plugin-tailwindcss' plugin enabled in its settings. Therefore, this rule should be disabled.

@athens-server
refactor: rename dialog hooks and reorganize file structure
9d86228 
- Rename dialog hooks to use kebab-case filenames
- Remove nested index files for dialog hooks
- Simplify export structure for dialog hooks

fix: standardize dialog content width and error text classes

- Remove `w-full` class from Dialog.Content components
- Reorder error text classes for consistency across user management dialogs

fix: adjust user dialog UI details

- Modify info icon positioning in create user dialog
- Reorder error text classes for consistency
- Use useEffect to reset form values in edit user dialog

refactor: remove form components from user management dialogs

- Inline dialog form logic directly into dialog components
- Remove separate form components for create, edit, delete, reset password, and remove admin dialogs
- Simplify dialog structure by consolidating form and dialog logic
- Update locales to support new dialog translations

fixes dialogs width

decapitalize

fix cancels buttons

refactor: standardize import paths in user management components

- Replace relative imports with absolute paths using @/ prefix
- Maintain relative imports in index.ts files
- Update import paths in dialog components and providers

added locales

fixes

added empty state

added error state

added skeleton and nodata

refactor dialogs

added state provider

caption props

added no search results state

paddings refactor

remove unnecesary props drilling

remove classes sorting

refactor remove unnecessary props drilling

fix-margins

first versions of modals

replace text with span

change eslint rule due to conflict between prettier and eslint, prettier already sort classnames

Adds promisifyMutation helper to simplify mutation handling
Updates user management handlers to use the helper
Adds proper typing for handlers using IDataHandlers interface
Removes duplicate type definitions

added search query

make pagination using usePaginationQueryStateWithStore

fixes code-review: remove onErrors callbacks

fix enter

fix pathes

refactoring dialogs

refactoring types

commit: refactor: use store provider for user management hooks
This commit refactors the user management page to use a centralized store provider by:
Creating UserManagementStoreProvider to manage shared hooks
Removing hook props drilling through components
Accessing hooks via useUserManagementStore hook in child components
Splitting UserManagementPage into container and content components
This change improves code organization and reduces prop drilling while maintaining existing functionality.

commit: refactor: move dialog context to providers directory
This commit reorganizes the dialog-related code by:
Moving DialogsProvider from context/ to providers/ directory
Updating import paths across components to use the new location
3. Removing unused context files and types
Consolidating dialog-related code for better maintainability
This is a structural change that improves code organization while maintaining existing functionality.

remove redundant index from dialog

commit: refactor: migrate dialog state management to UI layer
The commit refactors the user management dialog state handling by:
Moving dialog state management from container to UI layer using DialogsProvider
Converting mutation handlers to return Promises for proper async handling
Removing redundant dialog state management code from container
Consolidating error and loading states into dedicated objects
Moving EActiveTab enum to UI package for better organization
This change improves separation of concerns by keeping UI state management in the UI layer while maintaining the same functionality.

refactor: reorganize validation schemas and types

- Move Zod schemas to dedicated schema files
- Update type definitions to use schema inference
- Fix import paths to use absolute imports
- Remove duplicate schema definitions from components
- Centralize types in dedicated type files

refactor(user-management): reorganize dialogs structure

- Move all dialogs to dedicated folders with proper structure
- Add types and index files for each dialog
- Update imports and exports
- Add new translations for empty state
- Improve code organization in UserManagementPage

first version of filters and sorting

remove unnecessary fragment

added tabs

fixes after design review
@hiderr hiderr changed the base branch from pixel-point-onboarding to main January 31, 2025 14:38
@hiderr hiderr changed the base branch from main to pixel-point-onboarding January 31, 2025 14:38
@hiderr hiderr changed the base branch from pixel-point-onboarding to main January 31, 2025 14:46
@hiderr hiderr changed the base branch from main to pixel-point-onboarding January 31, 2025 14:57
@3em 3em changed the base branch from pixel-point-onboarding to main February 4, 2025 08:40
3em
3em reviewed Feb 4, 2025
View reviewed changes
apps/gitness/src/pages-v2/user-management/utils/promisify-mutation.ts
@@ -0,0 +1,10 @@
export type MutationFn<T> = (params: T, options: { onSuccess: () => void; onError: (error: any) => void }) => void
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ts ignore for any

3em
3em reviewed Feb 4, 2025
View reviewed changes
packages/ui/src/views/user-management/providers/dialogs-provider/dialogs-provider.tsx

export const DialogsContext = createContext<DialogsContextType | undefined>(undefined)

export const DialogsProvider = ({ children }: { children: React.ReactNode }) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove React. and add the types directly. Plz check all over ur code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3em 3em 3em left review comments

@iatopilskii iatopilskii iatopilskii left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiderr @3em @iatopilskii @athens-server