forked from harness/canary
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Pull Request labels (harness#928)
* fix: fix PR labels
- Loading branch information
Showing
33 changed files
with
872 additions
and
446 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 24 additions & 10 deletions
34
apps/design-system/src/subjects/views/pull-request-list/pull-request-list-store.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,39 @@ | ||
| import { noop } from '@utils/viewUtils' | ||
|
|
||
| export const pullRequestListStore = { | ||
| import { ColorsEnum, PullRequestListStore } from '@harnessio/ui/views' | ||
|
|
||
| export const pullRequestListStore: PullRequestListStore = { | ||
| pullRequests: [ | ||
| { | ||
| author: 'Administrator', | ||
| name: 'feat: create skeleton', | ||
| reviewRequired: true, | ||
| is_draft: false, | ||
| merged: null, | ||
| name: 'feat: create skeleton', | ||
| number: 34, | ||
| is_draft: false, | ||
| timestamp: 'Nov 14, 2024', | ||
| updated: 1731605604491, | ||
| sha: '1231', | ||
| author: 'Administrator', | ||
| reviewRequired: true, | ||
| sourceBranch: 'changes', | ||
| targetBranch: 'main', | ||
| state: 'open' | ||
| timestamp: 'Nov 14, 2024', | ||
| state: 'open', | ||
| updated: 1731605604491, | ||
| labels: [ | ||
| { | ||
| color: ColorsEnum.CYAN, | ||
| key: 'label-1', | ||
| value: 'value-1' | ||
| }, | ||
| { | ||
| color: ColorsEnum.RED, | ||
| key: 'label-2', | ||
| value: 'value-2' | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| totalPages: 1, | ||
| page: 1, | ||
| openPullReqs: 1, | ||
| closedPullReqs: 0, | ||
| setPage: noop, | ||
| setSearchQuery: null | ||
| setPage: noop | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
apps/gitness/src/pages-v2/pull-request/hooks/use-pr-conversation-labels.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import { useCallback, useMemo, useState } from 'react' | ||
|
|
||
| import { useAssignLabelMutation, useListLabelsQuery, useUnassignLabelMutation } from '@harnessio/code-service-client' | ||
| import { HandleAddLabelType, LabelAssignmentType } from '@harnessio/ui/views' | ||
|
|
||
| import { useGetRepoLabelAndValuesData } from '../../repo/labels/hooks/use-get-repo-label-and-values-data' | ||
|
|
||
| interface UsePrConversationLabelsProps { | ||
| repoRef: string | ||
| prId: number | ||
| refetchData: () => void | ||
| } | ||
|
|
||
| /** | ||
| * Hook that encapsulates all label-related operations | ||
| */ | ||
| export const usePrConversationLabels = ({ repoRef, prId, refetchData }: UsePrConversationLabelsProps) => { | ||
| const [searchLabel, setSearchLabel] = useState('') | ||
|
|
||
| const changeSearchLabel = useCallback((data: string) => { | ||
| setSearchLabel(data) | ||
| }, []) | ||
|
|
||
| const { labels, values: labelsValues } = useGetRepoLabelAndValuesData({ | ||
| query: searchLabel, | ||
| inherited: true, | ||
| limit: 100 | ||
| }) | ||
|
|
||
| const { data: { body: prLabels } = {}, refetch: refetchPRLabels } = useListLabelsQuery({ | ||
| repo_ref: repoRef, | ||
| pullreq_number: prId, | ||
| queryParams: {} | ||
| }) | ||
|
|
||
| const handleOnSuccess = () => { | ||
| refetchPRLabels() | ||
| refetchData() | ||
| } | ||
|
|
||
| const { mutate: addLabel } = useAssignLabelMutation( | ||
| { | ||
| repo_ref: repoRef, | ||
| pullreq_number: prId | ||
| }, | ||
| { | ||
| onSuccess: handleOnSuccess | ||
| } | ||
| ) | ||
|
|
||
| const { mutate: removeLabel } = useUnassignLabelMutation( | ||
| { | ||
| repo_ref: repoRef, | ||
| pullreq_number: prId | ||
| }, | ||
| { | ||
| onSuccess: handleOnSuccess | ||
| } | ||
| ) | ||
|
|
||
| const handleAddLabel = useCallback((body: HandleAddLabelType) => addLabel({ body }), [addLabel]) | ||
|
|
||
| const handleRemoveLabel = useCallback((label_id: number) => removeLabel({ label_id }), [removeLabel]) | ||
|
|
||
| const appliedLabels = useMemo(() => { | ||
| return (prLabels?.label_data || []) as LabelAssignmentType[] | ||
| }, [prLabels]) | ||
|
|
||
| return { | ||
| searchLabel, | ||
| changeSearchLabel, | ||
| labels, | ||
| labelsValues, | ||
| handleAddLabel, | ||
| handleRemoveLabel, | ||
| appliedLabels | ||
| } | ||
| } |
Oops, something went wrong.