Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Mathias,
thank you for aiming to improve the discovery of tests that exclusively fail on Windows within the test suite of CrateDB (crate/crate#11924). CI croaked on that because the upload process was invoked from PowerShell, so I tried to improve the situation already with crate/crate#11994.
However, there has been another incompatibility with Windows, discovered with CrateDB GHA build #4567182253. While this patch just sets the stage, #3 actually fixes it.
If you like the patch, you might want to assign a
secrets.WACKLIG_TOKEN
before acknowledging the CI run.With kind regards,
Andreas.
P.S.: Other than the test harness, 51168a1 brings in a small fix related to finding test report files recursively.
Running it on GHA's test matrix already succeeded, see wacklig-uploader GHA build #1596218664. The upload itself fails because a
WACKLIG_TOKEN
is not configured yet, but this currently gets ignored by usingcontinue-on-error: true
within the GHA recipe.Test coverage is 100%.