Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test harness #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add test harness #2

wants to merge 6 commits into from

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Dec 18, 2021

Dear Mathias,

thank you for aiming to improve the discovery of tests that exclusively fail on Windows within the test suite of CrateDB (crate/crate#11924). CI croaked on that because the upload process was invoked from PowerShell, so I tried to improve the situation already with crate/crate#11994.

However, there has been another incompatibility with Windows, discovered with CrateDB GHA build #4567182253. While this patch just sets the stage, #3 actually fixes it.

If you like the patch, you might want to assign a secrets.WACKLIG_TOKEN before acknowledging the CI run.

With kind regards,
Andreas.

P.S.: Other than the test harness, 51168a1 brings in a small fix related to finding test report files recursively.


Running it on GHA's test matrix already succeeded, see wacklig-uploader GHA build #1596218664. The upload itself fails because a WACKLIG_TOKEN is not configured yet, but this currently gets ignored by using continue-on-error: true within the GHA recipe.

Test coverage is 100%.

Name                        Stmts   Miss  Cover   Missing
---------------------------------------------------------
tests/conftest.py               4      0   100%
tests/test_environment.py      41      0   100%
tests/test_uploader.py         49      0   100%
wacklig.py                     55      0   100%
---------------------------------------------------------
TOTAL                         149      0   100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant