Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade react-cookie from 4.1.1 to 8.0.1 #5681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

caniszczyk
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • web/package.json
  • web/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
  529  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.64%. Comparing base (57c48c1) to head (2a4062e).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5681      +/-   ##
==========================================
- Coverage   25.66%   25.64%   -0.03%     
==========================================
  Files         474      481       +7     
  Lines       50905    51244     +339     
==========================================
+ Hits        13066    13141      +75     
- Misses      36848    37104     +256     
- Partials      991      999       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc
Copy link
Member

t-kikuc commented Mar 19, 2025

@hongky-1994 would you please check this PR? Not in a hurry.

even test/web fails 😓

@hongky-1994
Copy link
Contributor

hongky-1994 commented Mar 25, 2025

@hongky-1994 would you please check this PR? Not in a hurry.

even test/web fails 😓

@t-kikuc san,
I have added CookiesProvider to main component and test suite that occur error. This should fix the bug 🙏

References:

@t-kikuc t-kikuc force-pushed the snyk-fix-c469bc1e92f4803d61753793a4a35de5 branch from d0b4278 to 08336a5 Compare March 26, 2025 02:53
snyk-bot and others added 2 commits March 26, 2025 11:54
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-COOKIE-8163060

Signed-off-by: t-kikuc <[email protected]>
- Wrap CookiesProvider to root component
- Wrap CookiesProvider to error test that use cookies

Signed-off-by: kypham <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
@t-kikuc t-kikuc force-pushed the snyk-fix-c469bc1e92f4803d61753793a4a35de5 branch from 08336a5 to 2a4062e Compare March 26, 2025 02:55
@t-kikuc
Copy link
Member

t-kikuc commented Mar 26, 2025

@hongky-1994 Thank you so much for investigating and fixing it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants