Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: give a more clear recommendation about SELinux #20068

Merged
merged 10 commits into from
Feb 19, 2025
Merged

tiup: give a more clear recommendation about SELinux #20068

merged 10 commits into from
Feb 19, 2025

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 21, 2025 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

Extend the SELinux recommendations:

  • The config is in /etc/selinux/config.
  • On RedHat based systems there is /etc/sysconfig/selinux, which is a symlink to /etc/selinux/config. This symlink is not present on Ubuntu/Debian based systems.
  • On Ubuntu/Debian based systems SELinux tools are not installed by default, so getenforce and the config are not available until extra tools are installed.
  • On Ubuntu/Debian SELinux is not enabled by default, so no action is needed. Note that apparmor is used instead, but this isn't causing issues for TiDB/TiUP.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from bb7133 and qiancai January 21, 2025 06:37
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@dveeden dveeden added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Jan 21, 2025
@dveeden dveeden requested a review from breezewish January 21, 2025 10:55
@qiancai qiancai self-assigned this Jan 26, 2025
@qiancai
Copy link
Collaborator

qiancai commented Jan 26, 2025

/cc @bb7133 @breezewish

bb7133
bb7133 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 12, 2025

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai
qiancai reviewed Feb 12, 2025
View reviewed changes
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Feb 13, 2025
@qiancai qiancai mentioned this pull request Feb 13, 2025
Merged
15 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 13, 2025
@qiancai qiancai requested a review from lilin90 February 13, 2025 09:06
qiancai
qiancai reviewed Feb 13, 2025
View reviewed changes
lilin90
lilin90 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-19 06:33:05.390900073 +0000 UTC m=+1029427.787122127: ☑️ agreed by lilin90.
  • 2025-02-19 06:53:22.996079076 +0000 UTC m=+1030645.392301134: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Feb 19, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit a547209 into pingcap:master Feb 19, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20315.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 19, 2025
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20316.

This was referenced Feb 19, 2025
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2025
@ti-chi-bot
tiup: give a more clear recommendation about SELinux (#20068) (#20316)
36b016c
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2025
@ti-chi-bot
tiup: give a more clear recommendation about SELinux (#20068) (#20315)
40fef69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@lilin90 lilin90 lilin90 approved these changes

@qiancai qiancai qiancai approved these changes

@breezewish breezewish Awaiting requested review from breezewish

Assignees

@qiancai qiancai

Labels
approved area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @qiancai @ti-chi-bot @bb7133 @lilin90