Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JinaEncoder class to handle Jina Embeddings #59

Merged
merged 11 commits into from
Jan 14, 2024

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Dec 5, 2023

Adding JinaEncoder class to allow users to use Jina Embeddings using Jina Embedding API https://jina.ai/embeddings/

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Unit tests have been added

@JoanFM
Copy link
Contributor Author

JoanFM commented Dec 5, 2023

Adding unit tests to class

@JoanFM
Copy link
Contributor Author

JoanFM commented Dec 5, 2023

Adding unit tests to class

Done

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoanFM thank you very much for your contribution!

Please see only one comment about missing a system (==integration) test. Other than that LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For encoders that use external APIs, on top of the highly mocked unit test we also have a system test that verifies integration with the actual embedding service. Please see tests/system/test_openai_encoder for example.

Can you please add a similar system test for JinaEncoder?
These tests can assume that JINA_API_KEY env var has a valid API key, and we will add a relevant key to the CI's secrets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @igiloh-pinecone ,

System test added as request. Please check

The tests in this director will not be runnig in every PR's CI workflow, but in separate daily scheduled CI runs
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

auto-merge was automatically disabled January 11, 2024 15:35

Head branch was pushed to by a user without write access

@acatav acatav enabled auto-merge January 14, 2024 14:21
@acatav acatav added this pull request to the merge queue Jan 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2024
@acatav acatav added this pull request to the merge queue Jan 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2024
@acatav acatav added this pull request to the merge queue Jan 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2024
@acatav acatav added this pull request to the merge queue Jan 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2024
@igiloh-pinecone igiloh-pinecone added this pull request to the merge queue Jan 14, 2024
Merged via the queue into pinecone-io:main with commit c4fd2a1 Jan 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants