Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import examples in README #167

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update import examples in README #167

merged 1 commit into from
Oct 24, 2024

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Oct 24, 2024

Problem

The import examples in the README are missing some class imports.

Solution

Add the imports.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

Adding missing imports
@jseldess jseldess requested a review from rohanshah18 October 24, 2024 15:42
Copy link
Contributor

@rohanshah18 rohanshah18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jseldess jseldess merged commit 7e8807d into main Oct 24, 2024
8 of 9 checks passed
@jseldess jseldess deleted the README-fixes branch October 24, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants