Add support for OpenSearch as a database #300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daverigby
commented
Feb 21, 2025
There was a problem hiding this comment.
Generally looks good. As discussed before, I would try to get some basic integretion tests working for OpenSearch - see tests/integration/test_pgvector.py. If we can get a local Docker image working then it should be possible to ru the tests against that.
To your quesiton on metadata filtering, YFCC makes uses of metadata.
| # None specified, default to "vsb-<workload>" | ||
| self.index_name = f"vsb-{name}" | ||
|
|
||
| self.create_index() |
There was a problem hiding this comment.
You shouldn't need to call create_index() here, it should be sufficient to just do it in initialise_population.
daverigby
commented
Feb 28, 2025
| actions.append(action) | ||
| actions.append(vector_document) | ||
| # Bulk ingest documents | ||
| return self.client.bulk(body=actions,request_timeout=600) |
There was a problem hiding this comment.
Note: You don't need to retry the creation of the actions list - just move that into the head of insert_batch, and then have your do_insert_with_retry method just call self.client.bulk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the purpose of this change. What problem is being solved and why?
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change
Test Plan
Describe specific steps for validating this change.