Avoid spurious backtrace / log message on critical error #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On a critical error (e.g. existing index and --overwrite not specified), VSB prints a large amount of spurious / unnecessary output - e.g:
This causes the "CRITICAL" message to get somewhat lost.
Solution
Modify the handling of critical errors to use an explicit DoneFailed state in the state machine, which handles the shutdown without adding backtraces, also also updating messages to be more applicable to a failed run:
Type of Change