Remove dead code from dataset.py #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataset.py was original inherited from another project (locust-pinecone) which had slighly different requirements for parquet dataset usage. As new functionality has been added in VSB (iterator API, splitting batches), there is now code which is unused in dataset.py: * Generating queries by sampling passages (where a dataset doesn't have a queries set) - we expect a parquet dataset to always have a query set (and if not the actual workload subclass should provide one). * Directly upserting a parquet dataset into Pinecone (this is always done via the DB abstract base class). Delete the code related to this unused functionality to simplify maintenance of VSB.
daverigby
force-pushed
the
dataset_cleanup
branch
from
24fc3c4 to
f19a0e6
Compare
|
Partially addresses #46 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
dataset.py was original inherited from another project (locust-pinecone) which had slighly different requirements for parquet
dataset usage. As new functionality has been added in VSB (iterator API, splitting batches), there is now code which is unused in dataset.py:
Generating queries by sampling passages (where a dataset doesn't have a queries set) - we expect a parquet dataset to always have a query set (and if not the actual workload subclass should provide one).
Directly upserting a parquet dataset into Pinecone (this is always done via the DB abstract base class to support multiple databases).
Solution
Delete the code related to this unused functionality to simplify maintenance of VSB.
Type of Change
Test Plan
Rely on existing tests to ensure code is indeed all dead.