Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alarm): show keypad only for disarming #786

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rogelio-o
Copy link

@rogelio-o rogelio-o commented Oct 25, 2022

Description

Add a new configuration property in the alarm card to show the keypad only for disarming (when the alarm is not disarmed).

Related Issue

787 - [Feature]: show keypad only for disarming in alarm card

Motivation and Context

To improve the alarm card. There are alarms that can be configured only for requiring the code for disarming (e.g., securitas)

How Has This Been Tested

With my Home Assistant instance.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@piitaya
Copy link
Owner

piitaya commented Oct 26, 2022

Can we transform the boolean to a select (always, never, disarm) ? (empty default value will be never)

@rogelio-o
Copy link
Author

Can we transform the boolean to a select (always, never, disarm) ? (empty default value will be never)

Sure! Done in 5a0f502.

@rogelio-o rogelio-o force-pushed the feat/alarm-show-keypad-disarm branch from 0181308 to af1b875 Compare October 27, 2022 18:18
@fliespl
Copy link

fliespl commented May 3, 2023

@rogelio-o was this actually released? No show_keypad_disarm option on my end.

@rogelio-o rogelio-o force-pushed the feat/alarm-show-keypad-disarm branch from af1b875 to 3c20e1a Compare October 15, 2023 16:06
@rogelio-o
Copy link
Author

@piitaya I've rebased the branch and fixed the conflicts. Can you take a look? Thanks

"show_keypad": "Show keypad",
"always": "Always",
"never": "Never",
"disarm": "Disarmed"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"disarm": "Disarmed"
"disarm": "Disarm only"

"show_keypad": "Mostrar teclado",
"always": "Siempre",
"never": "Nunca",
"disarm": "Desarmado"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "disarm only", not "disarmed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants