Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(light-card) selection limit for light brightness #263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skrynklarn
Copy link
Contributor

Other sliders cards have ability so set a limit, min and max value, that user can select in the slider.

Example of use case:
Set min to 1, so it will be easier to the user to set 1% instead of 0 and turn off the light by accident.

@skrynklarn skrynklarn changed the title Selection limit for light brightness feat(light-card) selection limit for light brightness May 5, 2022
@skrynklarn
Copy link
Contributor Author

skrynklarn commented May 5, 2022

Update my branch and fixed merge conflicts. Also locally tested against HA 2022.05 and works fine

@piitaya Will you have a look on this feature when you have time? Thanks

@piitaya
Copy link
Owner

piitaya commented May 8, 2022

Do you have another use case for the min and max ? I'm not sure it's a good idea to add 2 new options for this.
Mushroom must stay simple so I don't think it's a good idea to add 2 options for only one use case.

@IceBotYT
Copy link

Do you have another use case for the min and max ?

Some lights (e.g. smart dimmers) don't change brightness after a certain value. 85% == 100% for example.

@skrynklarn
Copy link
Contributor Author

I use it for almost all my lights where I can change brightness so as before set min: 1 so it is not possible to turn it off with the slider. I also use it some some light to limit max brightness for me and also on some dashboards for my kids so they can not play as they like :) It could be useful for example if there is a volume slider to limit max (I know this PR is only for light)

No more use cases for me. I understand that mushroom is to be simple and I trying to use it instead of UI minimalist. But some small features missing and this was one for me.

One option would be to have that settings as ymal only. But that breaks the idea of mushroom as a ui config cards. But maybe for advanced/special settings that could be a option?

Don't know if it is possible but a collapsable "advanced settings" would be nice in card settings but have not seen any cards have it. Maybe something for Home assistant to add or if it can be done for custom cards.

Just some thoughts.

@Mrjwojc
Copy link

Mrjwojc commented Nov 30, 2022

Hi @skrynklarn Is your code merged? And if so, how to I use it when my Mushroom is at the current version?

@dannybloe
Copy link

I think this pull request solves one of the biggest problem I have with most sliders controlling lights and that is that it is almost impossible to set levels to very low percentages. I never ever want the option to set it to 0% just to turn off the lights. I never do that. Switching off the lights is always a toggle operation for me and never a slider operation. I have many people in my family complaing that they cannot use the slider to set low levels. Having that said, for this usability problem it would be good enough for me just to remove the option to set the level to 0% all together (min = 1) and have no setting for that. That would still keeps things simple. In fact: even more simpler because now you can use the lower range of the slider.

@RickeyWard
Copy link

I agree min/max are nice options for all sliders. My dimmer switches let me hardware set the max and min but I still would prefer to set most of the lights to 1% easily. I currently do that with call_services on doubletap action but friends and family don't know all my secret shortcuts.

@Snellingen
Copy link

The feature would be very welcome and is something that will fix #847 and feature #1217 (partially).
I have some lights that needs a max, but the most critical fix I need is to avoid turning off the lights when sliding to min brightness. This PR or either #848 will fix this. What is currently blocking these and what can we do to move this along?

@hanseandersson
Copy link

Im also looking for this!
Especially for light card to be able to slide all the way down and stop at 1% (either det as an option or atleast be able to yaml code it)

Also for media card to be able to set max volume to like 30% so kids won't get deaf when they control their own music 😂😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants