fix: header filter on knowledge query (#232)

picahq · Jan 28, 2025 · 47a2a60 · 47a2a60
1 parent a01407d
commit 47a2a60
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/api/src/logic/knowledge.rs b/api/src/logic/knowledge.rs
@@ -1,4 +1,4 @@
-use super::{read, HookExt, PublicExt, RequestExt};
+use super::{read_without_key, HookExt, PublicExt, RequestExt};
 use crate::server::{AppState, AppStores};
 use axum::{routing::get, Router};
 use entities::{Id, MongoStore};
@@ -8,8 +8,8 @@ use std::sync::Arc;
 
 pub fn get_router() -> Router<Arc<AppState>> {
     Router::new()
-        .route("/", get(read::<ReadRequest, Knowledge>))
-        .route("/:id", get(read::<ReadRequest, Knowledge>))
+        .route("/", get(read_without_key::<ReadRequest, Knowledge>))
+        .route("/:id", get(read_without_key::<ReadRequest, Knowledge>))
 }
 
 struct ReadRequest;

diff --git a/api/src/logic/mod.rs b/api/src/logic/mod.rs
@@ -170,6 +170,18 @@ where
     read_common::<T, U>(headers, access, query, State(state), true).await
 }
 
+pub async fn read_without_key<T, U>(
+    headers: HeaderMap,
+    query: Option<Query<BTreeMap<String, String>>>,
+    State(state): State<Arc<AppState>>,
+) -> Result<Json<ServerResponse<ReadResponse<Value>>>, PicaError>
+where
+    T: RequestExt<Output = U> + PublicExt<U> + 'static,
+    U: Serialize + DeserializeOwned + Unpin + Sync + Send + Debug + 'static,
+{
+    read_common::<T, U>(headers, None, query, State(state), true).await
+}
+
 pub async fn read_without_count<T, U>(
     headers: HeaderMap,
     access: Option<Extension<Arc<EventAccess>>>,