Skip to content

Add missing @method to ConstraintViolationInterface #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Mar 6, 2024

Not sure it's a wanted behavior, but if the stub does not declare all the @method annotation of the original file, method are considered as undefined. So I add them.

@VincentLanglet
Copy link
Contributor Author

Friendly ping @ondrejmirtes

@ondrejmirtes
Copy link
Member

I don' see these methods here https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/Validator/ConstraintViolationInterface.php I don't see why the stub should have them.

@ondrejmirtes
Copy link
Member

Please next time link them in the first message so I don't have to hunt for them myself. Thank you.

@ondrejmirtes ondrejmirtes merged commit 3fbf634 into phpstan:1.3.x Apr 12, 2024
@VincentLanglet VincentLanglet deleted the constraintViolation branch April 12, 2024 07:43
@VincentLanglet
Copy link
Contributor Author

Hi @ondrejmirtes this has been lost in the 1.4.x branch
https://github.com/phpstan/phpstan-symfony/blob/1.4.x/stubs/Symfony/Component/Validator/ConstraintViolationInterface.stub

Should I open another PR or is there some merge to do from 1.3.x to 1.4.x ?

Thanks

@ondrejmirtes
Copy link
Member

Merged 1.3.x into 1.4.x right now, sorry for forgetting.

@VincentLanglet
Copy link
Contributor Author

Merged 1.3.x into 1.4.x right now, sorry for forgetting.

No problem, thanks a lot for your reactivity. You're doing such a good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants