-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Voter stub #326
Introduce Voter stub #326
Conversation
I'm not sure that everyone who |
521bf82
to
0494e42
Compare
Same could be said for almost every stub I would say. I don't consider this stub as an hack or a wrong stub.
Symfony is a kinda slow adopter about new annotations as shown in symfony/symfony#46613 But I can start by this to get feedback and decide after for phpstan-symfony, sure. 👍 |
Hi @ondrejmirtes, the template was accepted by symfony in 6.3 symfony/symfony#49033 |
* | ||
* @param mixed $subject | ||
* | ||
* @phpstan-assert-if-true TSubject $subject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, fixed.
Thank you. |
Does such a stub require a test ?