Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature type for default-null parameters #3586

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 27, 2024

@staabm staabm marked this pull request as ready for review October 27, 2024 08:01
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

These kind of changes can be reviewed here: https://github.com/phpstan/phpstan-src/actions/runs/11643344314/job/32424024307

Please go through the diff and decide if there's a problem with this PR or not :)

@VincentLanglet
Copy link
Contributor

@staabm Hi, I wanted to work on phpstan/phpstan#12282 and just discovered your PR

Do you agree that phpstan/phpstan#7522 and phpstan/phpstan#12282 are duplicates ?

If your PR solves both, it could be great to rebase/target 2.1.x. (or do you want me to do it ?)

Thanks!

@staabm
Copy link
Contributor Author

staabm commented Mar 30, 2025

Hey 👋

Feel free to pick the commit and push a new PR

@VincentLanglet
Copy link
Contributor

Feel free to pick the commit and push a new PR

Sure, done with #3912

@staabm staabm closed this Mar 30, 2025
@staabm staabm deleted the bug7522 branch March 30, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function signature regression for ob_start with PHP 8.1?
4 participants