Fix MongoDB Manager stubs #2429
Conversation
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
GromNaN
force-pushed
the
mongodb-executebulkwrite
branch
from
92fa547 to
1a38d9e
Compare
GromNaN
force-pushed
the
mongodb-executebulkwrite
branch
from
1a38d9e to
708915e
Compare
resources/functionMap.php
Outdated
| 'MongoDB\Driver\Manager::executeDelete' => ['MongoDB\Driver\WriteResult', 'namespace'=>'string', 'filter'=>'array|object', 'deleteOptions='=>'array', 'writeConcern='=>'MongoDB\Driver\WriteConcern'], | ||
| 'MongoDB\Driver\Manager::executeInsert' => ['MongoDB\Driver\WriteResult', 'namespace'=>'string', 'document'=>'array|object', 'writeConcern='=>'MongoDB\Driver\WriteConcern'], |
There was a problem hiding this comment.
These two methods don't exist: https://www.php.net/manual/en/class.mongodb-driver-manager.php#mongodb-driver-manager.synopsis
There was a problem hiding this comment.
Did they ever exist? I think we need a script update this file for the ext-mongodb reference.
There was a problem hiding this comment.
No, these methods never existed.
Taking ext-mongodb source as reference. https://github.com/mongodb/mongo-php-driver/blob/master/src/MongoDB/Manager.stub.php
GromNaN
force-pushed
the
mongodb-executebulkwrite
branch
from
0dc1121 to
27d1114
Compare
There was a problem hiding this comment.
Updated MongoDB\Driver\Manager using ext-mongodb source stubs: https://github.com/mongodb/mongo-php-driver/blob/master/src/MongoDB/Manager.stub.php
Co-authored-by: Andreas Braun <[email protected]>
|
Replaced by #2473 |
Sync some outdated stubs while implementing rector on
mongodb/mongodb.Server::executeBulkWritehttps://github.com/mongodb/mongo-php-driver/blob/b93f7c2bd10f6f1710aadb0505045df2d221b3ea/src/MongoDB/Server.stub.php#L74-L79Manager::executeBulkWritehttps://github.com/mongodb/mongo-php-driver/blob/b93f7c2bd10f6f1710aadb0505045df2d221b3ea/src/MongoDB/Manager.stub.php#L18-L23Some outdated definition might still exist, I made a note to check it all later.